[Xastir-Dev] Re: [Xastir] disabling maps during redraw d/n work

[Curt Mills, WE7U]

I'm moving this to the developer's list instead of the user's list.
If you want to keep informed on the discussion Matt, you may want to
subscribe to the developer's list as well.


On Thu, 17 Jul 2003, Matt Werner wrote:

> I have found that disabling maps (using maps/disable all maps) during a
> redraw of maps doesn't disable them at all, but will eventually lead to maps
> displayed on the screen and the maps/disable all maps menu box checked.
>
> This is on a CVS version of xastir from around 7/16/03 on RH 9.0
>
> I submitted a bug report at sourceforge.net (I believe this was the correct
> way to handle it?).

Yes.  Correct method.

This one might need a bit of discussion.  The maps code was just
changed to allow the user to interrupt map drawing with new pan/zoom
commands in the middle of drawing.  At end end of each map file, we
now check for a map interrupt.  If found, start the map drawing
over (with the new drawing parameters).

Because of this checking, you're now able to input mouse and
keyboard commands during the map draw, where you weren't able to
before.

This opens up a big can of worms, as users are able to change menu
items during the map redraw.

For this specific case (ignoring the general problem for now), I
took a look at that toggle, and it sets the disable_all_maps
variable.  That variable is checked just prior to calling routines
like load_alert_maps() and load_maps().  It is not checked within
those routines.  That means if you disable maps after you told it to
draw maps, that variable won't take effect until the _next_ time you
are drawing maps or alert_maps.  As you experienced.

So... What do we want to do about the specific case?  General case?
Opinions?

-- 
Curt Mills, WE7U                    hacker_NO_SPAM_ at tc.fluke.com
Senior Methods Engineer/SysAdmin
"Lotto:    A tax on people who are bad at math!"
"Windows:  Microsoft's tax on computer illiterates!" -- WE7U
"The world DOES revolve around me:  I picked the coordinate system!"