[Xastir-dev] possible KISS protocol bug

[Curt Mills]

On Thu, 2 Dec 2004, f4dwv wrote:

> I try to use xastir 1.4.2 with an antic EVM56002 DSP card as KISS modem,
> and it did not work.
>
> Unity tests seem to show that the modem is OK, so I uncomment a fprintf
> in xastir to see the data stream send to the KISS modem and I see that
> xastir send a NULL after each frame :
> c0 01 28 c0 00 c0 02 3f c0 00 c0 03 14 c0 00 c0 04 1e c0 00 c0 05 00 c0
> 00 c0 00 82 a0 b0 62 68 64 60 8c 68 88 ae ac 40 60 a8 a4 82 86 8a 64 65
> 03 f0 3d 34 38 31 31 2e 33 20 4e 2f 30 30 31 33 37 2e 38 20 57 2d 50 48 47
>
> Rereading the KISS spec, it seems that it's not conform...
>
> Removing the 2 lines in interface.c that had the NULL cure the problem.
>
> Sure, my modem behave badly when man send it some NULL, but it seems to
> me that xastir don't have to send these NULL.
>
> am I completly wrong ?

You're probably completely right...

I'll try to take a look at this soon.  Can you send me a diff for
the lines that you had to change, or at least a pointer to them, so
I don't have to redo your debugging?

Thanks.

-- 
Curt, WE7U.				archer at eskimo dot com
http://www.eskimo.com/~archer
  Lotto:  A tax on people who are bad at math. - unknown
Windows:  Microsoft's tax on computer illiterates. - WE7U.
The world DOES revolve around me:  I picked the coordinate system!"