[Xastir] "Fix" for Cygwin compile problem

Tom Russo russo at bogodyn.org
Mon Nov 15 11:38:02 EST 2004


On Mon, Nov 15, 2004 at 08:20:55AM -0800, we recorded a bogon-computron collision of the <archer at eskimo.com> flavor, containing:
> On Mon, 15 Nov 2004, Gale D. Wilkinson wrote:
> 
> > This is what I get after a cvs update and ./bootstrap;sh, ./configure.
> > Just to be sure I did a full cvs download (not just a cvs update) this
> > morning to make sure that I had the latest stuff..
> 
> I had to make a change this weekend after Tom's change, as his broke
> my compiles, due to the USE_MAP_CACHE variable not being defined
> until after the headers are included.
> 
> Try moving the "#include <db.h>" line below the USE_MAP_CACHE stuff.

Heh.  And in between my change (which fixed builds without db and broke
builds without it) and yours (which unbroke builds *with* db and re-broke 
builds without) I installed db-4.2, so was no longer checking whether xastir 
built without it.

Sigh. 

Having the include of db.h inside the ifdef is the correct thing.  In fact,
if I had my druthers I'd have just about everything inside the ifdef
except for an include of config.h (which, at the moment, is indirectly
included by snprintf.h well down the line of includes).  If one isn't
using the map_cache code there's no point including all those other
headers.

-- 
Tom Russo    KM5VY     SAR502  DM64ux         http://www.swcp.com/~russo/
Tijeras, NM  QRPL#1592 K2#398  SOC#236 AHTB#1 http://www.qsl.net/~km5vy/
 "Politics consists of choosing between the disastrous and the unpalatable."
                                      -- John Kenneth Galbraith



More information about the Xastir mailing list