[Xastir] SHOW OF HANDS REQUESTED: Davis Weather Station users

[Tom Russo]

On Thu, Jul 19, 2012 at 02:12:19PM -0700, we recorded a bogon-computron collision of the <curt.we7u at gmail.com> flavor, containing:
> >
> > The patch I sent to Mike copied a compute_rain call out of other parts of the
> > code, but I'm not convinced it's right yet --- especially since the Meteo
> > code (which is used also by LaCrosse) pulls 24-hour data out of the wx station,
> > not total rain.
> 
> I remember having to add the rain computation code because some weather stations didn't provide enough data, or data in the correct format, that we needed.  Perhaps I messed up the Davis code at that point.  The weather code is a complete mess, but was so before I started hacking into it.  It could use a complete re-write.

No, the Davis code was added years after you added the rain computation code.

You were making comments about taking out parsing of Peet 24- and 1-hour
data in 2002, because it broke rain computation.  The Davis code (which
also parses 24- and 1-hour data, and does NOT provide total rain) was added
in 2004.  So if it's actually broken (which I'm increasingly convinced it is),
your adding the rain computation didn't do it.

Honestly, since the Davis provides the 24- and 1-hour data directly, the code
should be structured so that it doesn't recompute that data from total rain
if it's getting it from the rain gauge already.  But that will be difficult.
Also, the db2APRS code spits out an APRS-formatted string for weather, and
APRS-formatted weather strings don't have a space for total weather (only
24-hour, 1-hour, and since-midnight).  So "fixing" the Davis code would
involve breaking the supposed APRS formatting.  Right now, we take what *should*
be 24-hour data (pXXX) and store it as if it's total rain.

The meteo code (db2APRS) is clearly taking the 24 hour data out of the database
and feeding it to Xastir in the APRS string position for 24-hour data.  So is 
the LaCrosse code.  Xastir is then using it as if it's total rain (which 
increases continuously).  That's Just Wrong.

-- 
Tom Russo    KM5VY   SAR502   DM64ux          http://www.swcp.com/~russo/
Tijeras, NM  QRPL#1592 K2#398  SOC#236        http://kevan.org/brain.cgi?DDTNM
"And, isn't sanity really just a one-trick pony anyway? I mean all you get is
 one trick, rational thinking, but when you're good and crazy, oooh, oooh,
 oooh, the sky is the limit!"  --- The Tick