[Xastir] Error in Syslog

[Tom Russo]

That's very odd.  The only place where PF_INET and SOCK_PACKET are used in i
the code is in one place in interface.c where we're explicitly checking for
an old GLIBC version (prior to 2.3).  Only if Xastir was compiled against
such an old glibc are we supposed to be using that combination.  Otherwise
we're using PF_INET and SOCK_DGRAM instead.

One possibility is that the preprocessor symbols we're checking aren't 
correct anymore, and the ifdef is picking up the else clause instead of the
right one.   In fact, I think that's exactly what's going on here.  That
conditional is checking "__GLIBC_MINOR" instead of what I see in features.h,
__GLIB_MINOR__.  So it's picking up the old, deprecated block.

That block of code has existed since Chuck Byam put it in in 2003,so it is
very likely that the preprocessor symbol changed in the last 15 years.  It's
also likely that it's just an error.

I just experimented with fixing the preprocessor symbol so it actually
detects we're running with a newer GLIBC, and it made Xastir AX.25 connections
broken, so this code that has never actually been enabled isn't in fact
correct.  Turns out that replacing PF_INET,SOCK_PACKET with PF_INET,SOCK_DGRAM,
as is done in that block of code, was never right.  The correct thing is
to use AF_PACKET,SOCK_PACKET instead of PF_INET,SOCK_PACKET.  If I fix
the symbol *and* fix that usage, Xastir builds and does connect to an 
AX.25 interface correctly.  

I am testing this fix right now, and will push it when my fixed Xastir with 
AX.25 networking enabled has run a little longer.


On Sun, Jan 28, 2018 at 05:58:54PM +0000, we recorded a bogon-computron collision of the <kg4pid at yahoo.com> flavor, containing:
> Looking the the file /var/log/syslog, I noticed this...
> 'Jan 27 07:13:18 Igate kernel: [26779.439570] xastir uses obsolete (PF_INET,SOCK_PACKET)'
> 
> I don't have a clue what it means or if I should even worry about it. Anyone else see this?
> I just did an install a week ago so it's the latest version of xastir.
> Thanks, Max KG4PID??
> _______________________________________________
> Xastir mailing list
> Xastir at lists.xastir.org
> http://xastir.org/mailman/listinfo/xastir

-- 
Tom Russo    KM5VY   SAR502   DM64ux          http://www.swcp.com/~russo/
Tijeras, NM  QRPL#1592 K2#398  SOC#236        http://kevan.org/brain.cgi?DDTNM
 echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m]