[Xastir-Dev] Problems with snapshots?

[Jack Twilley]

WARNING: Unsanitized content follows.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Curt" == Curt Mills <Curt> writes:

Jack> I noticed something odd with my map display and attempted to
Jack> take a snapshot of it in order to share it here, when I noticed
Jack> that snapshots appeared to be broken.

Jack> /usr/local/bin/convert: Not a XPM image file
Jack> (/var/tmp/xastir_jmt_snap.xpm).  convert failed to convert
Jack> snapshot from xpm to png

Jack> I'm pretty sure this isn't me. :-) I have both XPM and
Jack> ImageMagick support compiled into my binary.  Any suggestions?
Jack> Curt, could this have been affected by something you've done to
Jack> solve the other graphics problems people have reported?

Curt> I looked into it a bit more: It looks like system() can return
Curt> with a value other than zero at times even when the command
Curt> succeeds.  We must check "errno" to see if an error actually
Curt> happened.  I added code to the snapshot routine to do just that,
Curt> and only emit the error message in that case.

That's not the problem here.  Two error messages were displayed -- one
directly from convert and one from xastir.  system() did return
something other than zero, because convert returned something other
than zero, because convert didn't consider
/var/tmp/xastir_jmt_snap.xpm to be a valid XPM image problem.

Curt> See if it still happens, and verify that snapshots are still
Curt> working.  You should perhaps see an XPM file in /var/tmp at
Curt> times, but then it should disappear and a PNG file should take
Curt> it's place, once every five minutes.

Curt> At some point our other system() calls should have similar code
Curt> added.  Not right now though.

At some point our system() calls should DIE DIE DIE. :-)

Jack.
(but look what happened the last time I said that...)
- -- 
Jack Twilley
jmt at twilley dot org
http colon slash slash www dot twilley dot org slash tilde jmt slash
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)

iD8DBQE+37QLGPFSfAB/ezgRAnaGAKD5UQMHxdTMHvRAgh6duVxJIaI3AgCg3obg
RFzggkgXu4m2h7oMGt/571k=
=qJOg
-----END PGP SIGNATURE-----