[Xastir-dev] Lots of good info hidden in the pull request discussions

Tom Russo russo at bogodyn.org
Tue Apr 16 08:37:59 PDT 2019


On Tue, Apr 16, 2019 at 08:15:22AM -0700, we recorded a bogon-computron collision of the <curt.we7u at gmail.com> flavor, containing:
> For those interested in learning more about Git and how the whole
> fork/pull-request thing works, a lot of good info is hidden away in the
> Xastir pull requests on Github.
> 
> I kind'a miss the larger development discussions that used to happen here
> on this mailing list. Maybe the Github discussions could be piped over here
> too, even if read-only? I haven't seen a way to do that yet.

We shouldn't be carrying on tangential discussions in pull requests, really.
We got carried away with commentary on #61, which would have been better
kept in email.  General discussion of how to do things in Git isn't what
pull request conversations are for.  That would be a good thing for this list
(or the users' list) instead.

I have a real problem with discussing specific issues related to a pull
request (which should be focused on the real changes proposed in the pull 
request) anywhere but on Github --- by keeping it there, we encapsulate
the entire thread in one place so that all commentary appears in one web link,
and by referring to the pull request and issue (if any) by number (#61) in 
commit messages, we maintain a link between commits and tracked issues in a
clear and searchable way on github.

It is extraordinarily painful for me to search for discussions about
Xastir changes in old emails (I have Xastir emails dating back
almost 18 years) --- sure, there are email archives on line, but they're not easily searchable.  It is much, much easier for me to search git
history using git commands.  If git history is linked to github issues and
pull requests (as it automatically is if we use the issue number and pull
request number), then it becomes a piece of cake.  And I look back in history
a lot in attempt to figure out why and how certain changes were made.  Trying
to sync those changes with emails from the same period is nearly impossible.

So my preference is to keep all discussion of specific proposed changes (where
the proposal is actually done in a concrete pull request) in the pull request
system.

I would also like to see specific bugs opened as tracked issues on github
as well, because you can discuss the issue in an encapsulated manner right
there and tie those directly to pull requests when a real fix is found.

I would rather keep emails for general discussion, and not mix up the two.

-- 
Tom Russo    KM5VY
Tijeras, NM  

 echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m]



More information about the Xastir-dev mailing list