[Xastir] Object/item bugs

[Curt, WE7U]

On Fri, 13 Aug 2004, Tapio Sokura wrote:

> First of all, the object comment fields seem to start after a space in
> the actual APRS packet. This eats one byte from the 43 byte maximum, but
> the comment input fields seems to accomodate 43 bytes. When I checked my
> object packet at findu, the last byte was stripped off and the space was
> clearly visible.

I see this in both main.c:Setup_object_data() and Setup_item_data():


    // We need to tack the comment on the end, but need to make
    // sure we don't go over the maximum length for an object.
    if (strlen(comment) != 0) {

        // Add a space first.  It's required for multipoint polygons
        // in the comment field.
        line[strlen(line) + 1] = '\0';
        line[strlen(line)] = ' ';

        temp = 0;
        while ( (strlen(line) < 80) && (temp < (int)strlen(comment))) {
            line[strlen(line) + 1] = '\0';
            line[strlen(line)] = comment[temp++];
        }
    }


So the space is required for multipoint objects.  We could check
whether a multipoint object was in the comment field and only add
the space in that case.  I'll check into doing that.

--
Curt, WE7U			         http://www.eskimo.com/~archer
"Lotto:    A tax on people who are bad at math." -- unknown
"Windows:  Microsoft's tax on computer illiterates." -- WE7U
"The world DOES revolve around me:  I picked the coordinate system!"