[Xastir] interface control->networked agwpe->properties bug
Tom Russo
russo at bogodyn.org
Sun Sep 16 21:31:30 EDT 2007
On Sun, Sep 16, 2007 at 09:03:19PM -0400, we recorded a bogon-computron collision of the <kevin.paetzold at townisp.com> flavor, containing:
> It seems that I have found a bug (or an off by one line typo)
> in interface_gui.c. I noticed that I was unable to display
> (or modify) the properties of an AGWPE interface anymore. There
> is an #endif for "HAVE_DB" at line 8086 (from the previous case
> for DEVICE_SQL_DATABASE which is messing up the case statement
> for the DEVICE_NET_AGWPE case in routine "interface_option()"
Good catch. Thank you.
> A diff for the fix looks like:
>
> 8085a8086
> > #endif /* HAVE_DB */
> 8088d8088
> < #endif /* HAVE_DB */
Fixed in CVS.
> I would have sent the diff as an enclosure but i figured that is
> frowned upon.
Well, the more troublesome thing is using old-style diff instead of unified
diff --- it's harder to work with the old-style diff format when there's any
version clash at all. Next time please use "diff -u" instead of just plain
"diff" for maximum efficiency.
--
Tom Russo KM5VY SAR502 DM64ux http://www.swcp.com/~russo/
Tijeras, NM QRPL#1592 K2#398 SOC#236 AHTB#1 http://kevan.org/brain.cgi?DDTNM
"And, isn't sanity really just a one-trick pony anyway? I mean all you get is
one trick, rational thinking, but when you're good and crazy, oooh, oooh,
oooh, the sky is the limit!" --- The Tick
More information about the Xastir
mailing list