[Xastir] Xastir => Mysql

[Tom Russo]

On Sun, Jan 24, 2010 at 04:25:13AM -0500, we recorded a bogon-computron collision of the <w2swrster at gmail.com> flavor, containing:
> I recompiled it again, here is the capture from bash:
> 
[...]
>   Spatial database support ............... : yes
>   Spatial database Postgresql/Postgis .... : no
>   MySQL .................................. : yes
>   MySQL Spatial database support ......... : yes
> 
[...]
> 
> gcc -DHAVE_CONFIG_H -I. -I..   -I/usr/local/include -I/usr/include/mysql
> -DBIG_JOINS=1 -fno-strict-aliasing -DUNIV_LINUX -I/usr/include/ImageMagick
> -DXASTIR_DATA_BASE=\"/usr/local/share/xastir\"  -g -O2 -pipe -W -Wall
> -Wpointer-arith -Wstrict-prototypes -Wno-unused-parameter -pthread -MT
> db_gis.o -MD -MP -MF .deps/db_gis.Tpo -c -o db_gis.o db_gis.c
> db_gis.c: In function
> ?initConnections?:
> 
> db_gis.c:581: error: ?Connection? has no member named
> ?phandle?
> 
> db_gis.c: In function
> ?openConnection?:
> 
> db_gis.c:619: error: ?DB_POSTGIS? undeclared (first use in this
> function)
> 
> 
> db_gis.c:875: error: ?ConnStatusType? undeclared (first use in this
> function)
> 
> db_gis.c:875: error: expected ?;? before
> ?psql_status?
> 
> db_gis.c: In function
> ?testConnection?:
> 
> db_gis.c:956: error: ?ConnStatusType? undeclared (first use in this
> function)
> 
> db_gis.c:956: error: expected ?;? before
> ?psql_status?
> 
> db_gis.c:957: error: ?PGresult? undeclared (first use in this
> function)
> 
> db_gis.c:957: error: ?result? undeclared (first use in this
> function)


This appears to be an indication that the MySQL support in Xastir is broken.

I have looked over the code in db_gis.c and it is quite clear that it was
never really debugged for MySQL, only Postgresql.  There are numerous instances
of Postgres data structures being used outside of HAVE_POSTGIS ifdefs, and
a number of references to preprocessor macros outside of HAVE_POSTGIS ifefs that
are only defined inside HAVE_POSTGIS ifdefs.

My suggestion is to give up on MySQL for now and use PostGIS instead.  I 
suspect that the MySQL code has never been properly tested.  It is possible that
the MySQL code can be patched up to remove these errors, but right now it
is quite clearly broken.

Paul Morris wrote the spatial database code and the Wiki page that describes
setting it up.  Perhaps he can comment here on whether he ever actually got
MySQL Spatial working.  

-- 
Tom Russo    KM5VY   SAR502   DM64ux          http://www.swcp.com/~russo/
Tijeras, NM  QRPL#1592 K2#398  SOC#236        http://kevan.org/brain.cgi?DDTNM
  In some cultures what I do would be considered normal. 
                                  -- Ineffective daily affirmation