[Xastir] Bug Report - OSM PNG installation does not respect DESTDIR

[Tom Russo]

On Mon, Nov 08, 2010 at 07:20:08PM -0600, we recorded a bogon-computron collision of the <jerutley at gmail.com> flavor, containing:
> Curt, et al -
> 
> Tonite I was attempting to build latest stable version of Xasitr
> (2.0.0) into RPM form on my new Fedora 14 installation.  When I build
> RPMS, I use the very nice program "mock" which allows building of a
> src.rpm file within a chrooted enviornment, to ensure your build
> system stays pristine.  When I tried to do so, I found that there's at
> least one part of the generated Makefile that does not properly
> respect the DESTDIR variable.  In the makefile target
> install-data-hook, the following code exists:
> 
> 
> install-data-hook:
>         cd $(mapdir) && \
>         rm -f CC_OpenStreetMap.png && \
>         $(LN_S) CC_OpenStreetMap_logo.png CC_OpenStreetMap.png
> 
> However, when building with DESTDIR, this code bails due to the fact
> that it really should end up being:
>
> cd $(DESTDIR)/$(mapdir)
> 
> instead.

install-data-hook and install-exec-hook were not written to use DESTDIR as
they should have been.  Since they're very low-level hooks into the automake
system, one needs to be more careful with them.  

The correct cd would be "cd $(DESTDIR)$(mapdir)" which is still correct when
DESTDIR is null (yours would have forced an incorrect leading / in there).

I just committed the fix.

> Autoconf/Automake are not my strong point, so I have no clue how to
> properly fix this within that structure, but I thought it would be
> something you guys would want to know.
> 
> Jeremy, KE0MD
> _______________________________________________
> Xastir mailing list
> Xastir at lists.xastir.org
> http://lists.xastir.org/cgi-bin/mailman/listinfo/xastir

-- 
Tom Russo    KM5VY   SAR502   DM64ux          http://www.swcp.com/~russo/
Tijeras, NM  QRPL#1592 K2#398  SOC#236        http://kevan.org/brain.cgi?DDTNM
 "The truth will set you free, but first it will piss you off."