[Xastir] get-NWSdata script

[Tom Russo]

On Wed, Jul 05, 2017 at 01:40:41PM -0400, we recorded a bogon-computron collision of the <ve3ctp at cogeco.ca> flavor, containing:
> All was going well..until..
> 
> rchive:  c_11au16.zip
>   inflating: c_11au16.dbf            
>   inflating: c_11au16.prj            
>   inflating: c_11au16.shp            
>   inflating: c_11au16.shx            
> /usr/local/share/xastir/scripts/get-NWSdata: 114: /usr/local/share/xastir/scripts/get-NWSdata: Bad substitution

This line of the script is a recent addition by Curt, and appears to be
a bashism.  Many linux distros have /bin/sh as nothing more than an alias
for /bin/bash, but some don't --- and I believe that raspbian may be one
of those.  On my pi, /bin/sh is "dash", not bash.  On my BSD systems, 
/bin/sh is the original Bourne shell.

Curt might need to remove the bashism from get-NWSdata, since its "shebang"
explicitly lists /bin/sh, which may be the Bourne shell or dash on some
systems.  It is never safe to assume that /bin/sh is bash, and using
bash extensions in scripts with "#!/bin/sh" at the top is a no-no.

In the meantime, try editing get-NWSdata to replace "/bin/sh" with "/bin/bash"
and it should work.  This is not a general solution, as some operating 
systems don't install bash in /bin.  BSD, for example, puts it in 
/usr/local/bin.

> 
> From: Tom Russo
> Sent: July 5, 2017 1:01 PM
> To: Xastir - APRS client software discussion
> Subject: Re: [Xastir] get-NWSdata script
> 
> get-NWSdata accesses a helper script called "values" that must be present in 
> the same directory as the script.  It is created at configure time, and "make 
> install" will install them both to the same place.
> 
> It appears that you are trying to run the script that exists in the source tree.
> "values" may or may not be present there depending on how you built xastir.
> If you built using a separate "build directory" as we recommend, it won't
> be there: values will be created in your build directory, but get-NWSdata
> won't be copied in there.  If you are building directly in the source tree,
> values will be created at configure time, but not until then, and will be 
> removed if you do a "make distclean."
> 
> Once you do "make install" both get-NWSdata and values will be installed in
> ${prefix}/share/xastir/scripts.  In that case, you should run it from that 
> location, i.e. 'sudo /usr/local/share/xastir/scripts/get-NWSdata'
> 
> On Wed, Jul 05, 2017 at 10:49:09AM -0400, we recorded a bogon-computron collision of the <ve3ctp at cogeco.ca> flavor, containing:
> > sudo ./get-NWSdata 
> > 
> > I get command not found
> > 
> > Tried to execute from root
> > 
> > 
> > 
> > 
> > Sent from Mail for Windows 10
> > 
> > From: davidf4
> > Sent: July 5, 2017 1:44 AM
> > To: 'Xastir - APRS client software discussion'; 'Xastir - APRS client software discussion'
> > Subject: Re: [Xastir] get-NWSdata script
> > 
> > Not normal..Try this:
> > 
> > sudo ./get-NWSdata
> > 
> > 
> > -----Original Message-----
> > From: Xastir [mailto:xastir-bounces at lists.xastir.org] On Behalf Of
> > ve3ctp at cogeco.ca
> > Sent: Tuesday, July 04, 2017 9:40 PM
> > 
> > 
> > is this normal, or just me
> > 
> > pi at raspberrypi:~/src/Xastir/scripts $ sudo sh -x get-NWSdata
> > 
> > 
> > 
> > _______________________________________________
> > Xastir mailing list
> > Xastir at lists.xastir.org
> > http://xastir.org/mailman/listinfo/xastir
> > 
> > 
> > 
> > ---
> > This email has been checked for viruses by AVG.
> > http://www.avg.com
> > _______________________________________________
> > Xastir mailing list
> > Xastir at lists.xastir.org
> > http://xastir.org/mailman/listinfo/xastir
> 
> -- 
> Tom Russo    KM5VY   SAR502   DM64ux          http://www.swcp.com/~russo/
> Tijeras, NM  QRPL#1592 K2#398  SOC#236        http://kevan.org/brain.cgi?DDTNM
>  echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m]
> 
>  
> 
> 
> _______________________________________________
> Xastir mailing list
> Xastir at lists.xastir.org
> http://xastir.org/mailman/listinfo/xastir
> 

-- 
Tom Russo    KM5VY   SAR502   DM64ux          http://www.swcp.com/~russo/
Tijeras, NM  QRPL#1592 K2#398  SOC#236        http://kevan.org/brain.cgi?DDTNM
 echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m]