[Xastir] constant warnings in term after update and ipv6 (updated) isn't broke

[Tom Russo]

On Sat, Nov 17, 2018 at 10:54:58AM -0500, we recorded a bogon-computron collision of the <xastir at deej.net> flavor, containing:
> I can confirm that doing:
> export LANG="C"
> then running Xastir in the same shell eliminates the "Character \260" 
> warning messages at initial startup.
> 
> However, the messages start appearing after running awhile.?? Moving the 
> mouse cursor over the Xastir main screen seems to cause it.

I have been running all night without any such errors after last night's
changes, which should have eliminated the need for setting LANG=C.

The generation of the warning while moving around on the screen is 
probably due to the drawing of degree symbols in the small text area at 
the bottom of the screen.  I do not see these warnings at this point, with or 
without LANG=C, so I did not wrap the code that draws there in these
set/restore C locale calls.  

Since I can't reproduce these warnings on my system anymore, I'll have to 
leave it to someone else to hunt down the remaining issues. 

> On 11/17/2018 1:16 AM, Tom Russo wrote:
> > I just undid *part* of my recent commit.  I left the part that actually
> > fixed the warning, but undid a bit that changed the behavior of the "Station
> > Info" dialog.
> >
> > I discovered that after my last commit, the degree sign rendered strangely
> > in the Station Info scrollable text widget --- rather than just be a degree
> > sign, it rendered as A with a circumflex followed by a degree sign.  I was
> > unable to fix the code in db.c to stop doing that --- the only time it was
> > right was if LANG=C had been set before running Xastir; setting via
> > set_to_C_locale before rendering the text and restoring afterward did the
> > wrong thing.
> >
> > When I took these calls out of db.c, I discovered that the station info
> > dialog didn't show a degree sign at all, but also didn't spew the warning.
> > This was actually how it was before I started hacking (i.e. it was already
> > broken).
> >
> > Since I can't figure out how to fix it, I reverted to what was there earlier
> > today.
> >
> > So as of now, the warnings are gone and the map renders the degree symbol
> > correctly.  But the station info dialog is borken if LANG is not C (or empty),
> > showing "Bearing to my station" as a number with no degree sign at all.
> >
> > If anyone else wants to hack on it, you'd have to look for the places where
> > "station_data_fill_in" writes bearing data into si_text using XmTextInsert.
> >
> > Near as I can tell, if the si_text widget is created while locale is C, it's
> > all good as far as the degree sign goes, but then other rendering of text
> > in other languages may be busted.  it doesn't seem to be enough to change
> > the locale while *writing* into that text widget if the locale wasn't C
> > at the time the widget was created.
> >
> > At any rate, I'm giving up.  At least the warnings are gone and the map has
> > the degree symbol rendered correctly irrespective of LANG setting.
> >
> >
> _______________________________________________
> Xastir mailing list
> Xastir at lists.xastir.org
> http://xastir.org/mailman/listinfo/xastir

-- 
Tom Russo    KM5VY
Tijeras, NM  

 echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m]