[Xastir-Dev] does it make sense to start killing globals?

Derrick J Brashear shadow at dementia.org
Wed Jul 2 12:32:11 EDT 2003


On Wed, 2 Jul 2003, Curt Mills, WE7U wrote:

> > In the same vein, I see places with code duplication. Here, however, the
> > variables change. I assume for the simple reason of "pain to debug" that
> > switching to using preprocessor macros is right out?
>
> I don't see that as being much more complicated to debug.  If it
> makes sense to do that here and there, I'm for it.

There was some project I was trying to use that involved a lot of math, it
had a large function which was just a nested set of preprocessor macros. I
got a core somewhere in the middle.

> Making the code pretty at the expense of making it harder to
> understand/maintain is out.  Removing duplicated code and
> streamlining things, making the code _easier_ to follow/maintain is
> in.

Good enough. I suppose it's acceptable as long as it's not taken to
extreme.



More information about the Xastir-dev mailing list